Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ioutil with io and os #198

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

estensen
Copy link
Contributor

ioutil was deprecated in Go 1.16

@@ -1,10 +1,11 @@
//go:build go1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these build tags? Can we remove them entirely..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's out of scope for this PR, but I'm happy to create another PR removing them. This build line is added because Go 1.17 has a new syntax for them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair.

Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Just a question about the go1.4 build tags.

@mfridman
Copy link
Member

cc @golang-jwt/maintainers what are your thoughts?

@oxisto
Copy link
Collaborator

oxisto commented May 27, 2022

cc @golang-jwt/maintainers what are your thoughts?

Fine by me.

@mfridman mfridman merged commit f6c6299 into golang-jwt:main May 27, 2022
@estensen estensen deleted the ioutil branch May 30, 2022 07:49
oxisto pushed a commit to moneszarrugh/jwt that referenced this pull request Feb 21, 2023
oxisto added a commit to twocs/jwt that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants