-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: TestTCPServer flaky on macOS 10.12 builders #32919
Comments
Compare #32534. |
Another |
|
Seems like we have enough of these to form a pattern. |
|
|
|
It would be interesting to know whether this ever occurs on a version of Darwin later than 10.12. |
Looks like it hasn't so far: |
That suggests that this may be the same underlying issue as #22019. |
Change https://golang.org/cl/202618 mentions this issue: |
Change https://golang.org/cl/202561 mentions this issue: |
My fix in CL 202618 inadvertently violated an invariant in the inner loop of TestTCPServer (namely, that len(trchs) == i). That causes a panic when one or more of the channels is omitted due to a flake. Instead of trying to fix up the test, let's just factor out a subtest and skip the whole thing if the transceiver's Dial flakes out. Updates #32919 Change-Id: Ib6f274a44194311c8c5a2faf19f586cc9eccfd4d Reviewed-on: https://go-review.googlesource.com/c/go/+/202561 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
From https://build.golang.org/log/19f0ac1d66a927076b256862638641e261489304 on the
darwin-amd64-race
builder:CC @mikioh @ianlancetaylor
The text was updated successfully, but these errors were encountered: