-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: total allocation stats are managed in a uintptr
which can quickly wrap around on 32-bit architectures [1.17 backport]
#52688
Comments
Basically, on 32-bit platforms, allocation stats can end up completely wrong. I'm surprised this flew under the radar for so long. There's no workaround. |
Just checking in. The next minor release is coming up soon, and this issue has already been bumped once. Is there any new progress? |
Change https://go.dev/cl/411496 mentions this issue: |
Closed by merging b1be664 to release-branch.go1.17. |
…ats as uint64 Currently the consistent total allocation stats are managed as uintptrs, which means they can easily overflow on 32-bit systems. Fix this by storing these stats as uint64s. This will cause some minor performance degradation on 32-bit systems, but there really isn't a way around this, and it affects the correctness of the metrics we export. For #52680. Fixes #52688. Change-Id: I8b1926116e899ae9f03d58e0320bcb9264945b3e Reviewed-on: https://go-review.googlesource.com/c/go/+/411496 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com>
@mknyszek requested issue #52680 to be considered for backport to the next 1.17 minor release.
The text was updated successfully, but these errors were encountered: