Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: go1.18 release notes for CLs 323318/332771 #49588

Closed
wants to merge 1 commit into from
Closed

doc: go1.18 release notes for CLs 323318/332771 #49588

wants to merge 1 commit into from

Conversation

CAFxX
Copy link
Contributor

@CAFxX CAFxX commented Nov 15, 2021 •
edited
Loading

Updates #47694

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 15, 2021
CAFxX
CAFxX commented Nov 15, 2021
View reviewed changes
doc/go1.18.html Outdated Show resolved Hide resolved
doc/go1.18.html Outdated Show resolved Hide resolved
@gopherbot
Copy link
Contributor

This PR (HEAD: 82b4adb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363840 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 1: Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 111e2e7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363840 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: e2f1cda) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363840 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 177e920) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363840 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carlo Alberto Ferraris:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 4: Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 4: Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2bb2d27) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363840 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@CAFxX
doc: go1.18 release notes for CLs 323318/332771
05b9649 
Updates golang#47694

Change-Id: Ida662b637396eb967e759be231d79330ef4f6163
@gopherbot
Copy link
Contributor

Message from Carlo Alberto Ferraris:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 05b9649) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/363840 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carlo Alberto Ferraris:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/363840.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 27, 2021
@CAFxX @ianlancetaylor
doc: go1.18 release notes for CLs 323318/332771
a142d65 
Updates #47694

Change-Id: Ib76737996a701906117e096eb6d05b388576a874
GitHub-Last-Rev: 05b9649
GitHub-Pull-Request: #49588
Reviewed-on: https://go-review.googlesource.com/c/go/+/363840
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Daniel Martí <mvdan@mvdan.cc>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/363840 has been merged.

@gopherbot gopherbot closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAFxX @gopherbot