make.bat: handle spaces in path when determining bootstrap version #54270
Conversation
|
This PR (HEAD: 7ab766b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/421356 to see it. Tip: You can toggle comments from me using the |
|
Message from Dominic Della Valle: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Dominic Della Valle: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
Single quotes don't account for whitespace in this context, which causes output to look like this: 'C:\Program' is not recognized as an internal or external command, operable program or batch file. Building Go cmd/dist using C:\Program Files\Go. (go version =) When it should look like this: Building Go cmd/dist using C:\Program Files\Go. (go1.19 windows/amd64)
|
This PR (HEAD: a01fda6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/421356 to see it. Tip: You can toggle comments from me using the |
|
Message from Dominic Della Valle: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Dominic Della Valle: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Dominic Della Valle: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
dmitshur
changed the title
|
Message from Dmitri Shuralyov: Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Alex Brainman: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
Message from Ian Lance Taylor: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
Single quotes don't account for whitespace in this context, which causes output to look like this: $ ./make.bat 'C:\Program' is not recognized as an internal or external command, operable program or batch file. Building Go cmd/dist using C:\Program Files\Go. (go version =) When it should look like this: Building Go cmd/dist using C:\Program Files\Go. (go1.19 windows/amd64) For #44505. Change-Id: I71328add5c74bd2829c0e23224cfa6252395ff2c GitHub-Last-Rev: a01fda6 GitHub-Pull-Request: #54270 Reviewed-on: https://go-review.googlesource.com/c/go/+/421356 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
|
Message from Dmitri Shuralyov: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/421356. |
|
This PR is being closed because golang.org/cl/421356 has been merged. |
Single quotes don't account for whitespace in this context, which causes
output to look like this:
$ ./make.bat
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
Building Go cmd/dist using C:\Program Files\Go. (go version =)
When it should look like this:
Building Go cmd/dist using C:\Program Files\Go. (go1.19 windows/amd64)
For #44505.