Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix: add AT_EACCESS on Darwin #153

Closed
wants to merge 2 commits into from
Closed

unix: add AT_EACCESS on Darwin #153

wants to merge 2 commits into from

Conversation

MKuranowski
Copy link
Contributor

The AT_EACCESS constant, used by faccessat syscall is present on Linux, Solaris and other BSD platforms. This commit also adds this constant on Darwin.

The constant (and the associated faccessat syscall) is part of POSIX.1-2008.

Fixes golang/go#59265.

@google-cla
Copy link

google-cla bot commented Mar 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MKuranowski
unix: add AT_EACCESS on Darwin
28082ec 
The AT_EACCESS constant, used by faccessat syscall is
present on Linux, Solaris and other BSD platforms.
This commit also adds this constant on Darwin.

The constant (and the associated faccessat syscall)
is part of POSIX.1-2008.

Fixes golang/go#59265.
@MKuranowski MKuranowski mentioned this pull request Mar 29, 2023
Closed
@gopherbot
Copy link

This PR (HEAD: 28082ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/480115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Mikołaj Kuranowski:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Tobias Klauser:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@MKuranowski
unix: generate AT_EACCESS in ztypes_darwin_*
a6a16c4 
This change includes the automatically generated AT_EACCESS constant;
based on its definition in types_darwin.go.
@gopherbot
Copy link

This PR (HEAD: a6a16c4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/480115 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Mikołaj Kuranowski:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Tobias Klauser:

Patch Set 2: Auto-Submit+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Tobias Klauser:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Matthew Dempsky:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/480115.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 3, 2023
@MKuranowski @gopherbot
unix: add AT_EACCESS on Darwin
90abad3 
The AT_EACCESS constant, used by faccessat syscall is present on Linux, Solaris and other BSD platforms. This commit also adds this constant on Darwin.

The constant (and the associated faccessat syscall) is part of POSIX.1-2008.

Fixes golang/go#59265.

Change-Id: Iae0ac35107cc291eba523cc88e68d3a9ddb7d01e
GitHub-Last-Rev: a6a16c4
GitHub-Pull-Request: #153
Reviewed-on: https://go-review.googlesource.com/c/sys/+/480115
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/480115 has been merged.

@gopherbot gopherbot closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/sys/unix: Missing AT_EACCESS on non-Linux Unix systems
2 participants
@MKuranowski @gopherbot