Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: hide Go Dlv Dap (Experimental) configuration from the stable version. #960

Closed
hyangah opened this issue Nov 24, 2020 · 3 comments
Closed

debug: hide Go Dlv Dap (Experimental) configuration from the stable version. #960

hyangah opened this issue Nov 24, 2020 · 3 comments
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone
v0.19.1

Comments

@hyangah
Copy link
Contributor

hyangah commented Nov 24, 2020

We enabled it in the stable version to allow more users to participate in the new feature testing
#23
But it requires the dev versions of Delve, and it is missing some important features.
I propose we hide it from the stable version for now and re-enable it as Delve is released for 1.16
or the extension has a solution to manage a separate version of delve for this feature.

cc/ @polinasok @suzmue
@hyangah hyangah added Debug Issues related to the debugging functionality of the extension. DelveDAP labels Nov 24, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/273046 mentions this issue: [release] package.json: skip godlvdap debug config in the stable version

gopherbot pushed a commit that referenced this issue Nov 30, 2020
@hyangah
[release] package.json: skip godlvdap debug config in the stable version
38dce0d 
We want to do more polishing on the Go Delve DAP debug option.
Until then, hide this in the stable version of the extension.

I hoped that I could disable that from the quick pick option
but I couldn't find how. (Not registering the debug config
provider didn't do the job).

I left goMain.ts untouched - it seems like it doesn't affect
visibility of the configuration.

This is a patch only applied to the release, and latest branches.
Not the main branch where nightly is built from.
Nightly will keep presenting the godlvdap option.

Fixes #960

Change-Id: I1afe8104a4e1b0e654727ec1fa574acccbd43605
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273046
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@hyangah
Copy link
Contributor Author

hyangah commented Dec 1, 2020

Not sure why gopherbot doesn't close this.
The change will be included in the next stable release 0.19.1

@hyangah hyangah closed this as completed Dec 1, 2020
@hyangah hyangah mentioned this issue Dec 1, 2020
Closed
@niteeshhegde
Copy link

Good to see some progress after waiting so long

@hyangah hyangah added this to the v0.19.1 milestone Dec 8, 2020
@polinasok polinasok mentioned this issue Jan 13, 2021
Closed
@golang golang locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Milestone
v0.19.1
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @niteeshhegde