Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run linter goanalysis_metalinter: rowserrcheck: failed prerequisites #1011

Closed
3 tasks done
sagikazarmark opened this issue Apr 3, 2020 · 8 comments
Closed
3 tasks done
Labels
bug Something isn't working cursed This issue is doomed.

Comments

@sagikazarmark
Copy link

sagikazarmark commented Apr 3, 2020

Thank you for creating the issue!

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

Please include the following information:

Version of golangci-lint
$ golangci-lint --version
golangci-lint has version 1.24.0 built from 6fd4383 on 2020-03-15T11:30:52Z
Config file
$ cat .golangci.yml
linters-settings:
    golint:
        min-confidence: 0.1
    goimports:
        local-prefixes: logur.dev/logur

linters:
    enable-all: true
    disable:
        - funlen
        - wsl
        - gomnd
Go environment
$ go version && go env
Go 1.14 on GitHub Actions
Verbose output of running
$ golangci-lint run -v
2020-04-03T15:00:24.3581925Z level=warning msg="[runner] Can't run linter goanalysis_metalinter: rowserrcheck: failed prerequisites: [buildssa@logur.dev/logur_test [logur.dev/logur.test]: analysis skipped: errors in package: [/home/runner/work/logur/logur/logger_context_test.go:29:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:29:48: cannot use *testLogger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:49:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:49:48: cannot use *testLogger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:77:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:77:48: cannot use *testLogger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:83:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_context_test.go:88:10: cannot use logger (variable of type *logur.TestLogger) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_context_test.go:97:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_context_test.go:102:10: cannot use logger (variable of type *logur.TestLoggerFacade) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_fields_test.go:30:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:30:48: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:51:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:51:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:57:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_fields_test.go:60:73: cannot use logger (variable of type *logur.TestLogger) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_fields_test.go:69:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_fields_test.go:72:73: cannot use logger (variable of type *logur.TestLoggerFacade) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_test.go:43:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:43:46: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:63:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:63:46: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:83:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:83:46: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:124:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:124:46: cannot use *(testLogger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:208:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:208:84: cannot use events[0] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:209:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:209:48: cannot use events[1] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:210:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:210:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:213:18: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_testing_test.go:216:19: cannot use logger (variable of type *logur.TestLogger) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_testing_test.go:245:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:245:84: cannot use events[0] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:246:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:246:48: cannot use events[1] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:247:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:247:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:251:18: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_testing_test.go:254:41: cannot use logger (variable of type *logur.TestLoggerContext) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_testing_test.go:308:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:308:84: cannot use events[0] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:309:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:309:92: cannot use events[1] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:310:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:310:48: cannot use events[2] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:311:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:311:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:314:18: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_testing_test.go:317:19: cannot use logger (variable of type *logur.TestLoggerFacade) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/standard_logger_test.go:33:37: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/standard_logger_test.go:33:44: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/standard_logger_test.go:58:37: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/standard_logger_test.go:58:44: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual]]"
2020-04-03T15:00:24.3630119Z level=error msg="Running error: rowserrcheck: failed prerequisites: [buildssa@logur.dev/logur_test [logur.dev/logur.test]: analysis skipped: errors in package: [/home/runner/work/logur/logur/logger_context_test.go:29:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:29:48: cannot use *testLogger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:49:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:49:48: cannot use *testLogger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:77:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:77:48: cannot use *testLogger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_context_test.go:83:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_context_test.go:88:10: cannot use logger (variable of type *logur.TestLogger) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_context_test.go:97:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_context_test.go:102:10: cannot use logger (variable of type *logur.TestLoggerFacade) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_fields_test.go:30:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:30:48: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:51:38: cannot use logEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:51:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_fields_test.go:57:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_fields_test.go:60:73: cannot use logger (variable of type *logur.TestLogger) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_fields_test.go:69:20: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_fields_test.go:72:73: cannot use logger (variable of type *logur.TestLoggerFacade) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_test.go:43:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:43:46: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:63:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:63:46: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:83:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:83:46: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:124:39: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_test.go:124:46: cannot use *(testLogger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:208:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:208:84: cannot use events[0] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:209:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:209:48: cannot use events[1] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:210:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:210:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:213:18: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_testing_test.go:216:19: cannot use logger (variable of type *logur.TestLogger) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_testing_test.go:245:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:245:84: cannot use events[0] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:246:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:246:48: cannot use events[1] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:247:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:247:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:251:18: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_testing_test.go:254:41: cannot use logger (variable of type *logur.TestLoggerContext) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/logger_testing_test.go:308:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:308:84: cannot use events[0] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:309:37: cannot use (LogEvent literal) (value of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:309:92: cannot use events[1] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:310:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:310:48: cannot use events[2] (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:311:37: cannot use lastEvent (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:311:48: cannot use *logger.LastEvent() (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/logger_testing_test.go:314:18: cannot use (func(_ Level) (Logger, conformance.TestLogger) literal) (value of type func(_ logur.Level) (logur.Logger, conformance.TestLogger)) as func(level logur.Level) (logur.Logger, conformance.TestLogger) value in struct literal /home/runner/work/logur/logur/logger_testing_test.go:317:19: cannot use logger (variable of type *logur.TestLoggerFacade) as conformance.TestLogger value in return statement: wrong type for method Events /home/runner/work/logur/logur/standard_logger_test.go:33:37: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/standard_logger_test.go:33:44: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/standard_logger_test.go:58:37: cannot use event (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual /home/runner/work/logur/logur/standard_logger_test.go:58:44: cannot use *(logger.LastEvent()) (variable of type logur.LogEvent) as logur.LogEvent value in argument to logtesting.AssertLogEventsEqual]]"

Here is the log on GitHub:

https://github.com/logur/logur/runs/558348594?check_suite_focus=true

Disabling rowserrcheck is not enough:

https://github.com/logur/logur/runs/558551895?check_suite_focus=true

Cannot reproduce it locally though.

@umputun
Copy link

umputun commented Apr 7, 2020

I'm having a similar issue. Randomly CI build fails like this: https://github.com/umputun/remark42/runs/568704660?check_suite_focus=true#step:7:43

go 1.14, golangci-lint 1.24

@tommyalatalo
Copy link

tommyalatalo commented Apr 13, 2020

I am also having this issue, the linter throws these prerequisite errors.

@bishtawi
Copy link

Im running into the same problem. Also, this issue looks to be a duplicate of #995 which was created due to the original issue #827 getting closed.

@ernado ernado added the bug Something isn't working label Apr 22, 2020
@ernado
Copy link
Member

ernado commented Apr 22, 2020

This is very cryptic and flaky bug :(
I will try to investigate, but no ETA, sorry.

Can you confirm that 1.23.8 has no issues?

@ernado ernado added the cursed This issue is doomed. label Apr 22, 2020
@umputun
Copy link

umputun commented Apr 22, 2020

Can you confirm that 1.23.8 has no issues?

yes

@bishtawi
Copy link

Yup, using 1.23.8 with Go 1.14 seems to be fine. Its only when I upgrade to 1.24 does the bug reproduce consistently.

ernado added a commit that referenced this issue Apr 22, 2020
Hotfix for `failed prerequisites` errors.
Actual cause is still unknown.

Revert: #987
Ref: #994, #995, #1011
@ernado
Copy link
Member

ernado commented Apr 22, 2020

Please try v1.25.0 version, this issue should be resolved.

@umputun
Copy link

umputun commented Apr 23, 2020

I have switched to 1.25.0. So far so good, but had just a few builds on GitHub actions

jirfag added a commit that referenced this issue May 3, 2020
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (`unused`). Clear it when it
becomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except `unused`.

Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4

Also in this commit:
  * speed up loading packages from export data (2.5s -> 2.1s for std)
    by not using mutex for export data since it was allowed in
    x/tools#07722704da13
  * make an order of execution of linters stable
  * update renameio and robustio
  * use robustio in caching

Relates: #987, #994, #995, #1011
jirfag added a commit that referenced this issue May 3, 2020
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (`unused`). Clear it when it
becomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except `unused`.

Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4

Also in this commit:
  * speed up loading packages from export data (2.5s -> 2.1s for std)
    by not using mutex for export data since it was allowed in
    x/tools#07722704da13
  * make an order of execution of linters stable
  * update renameio and robustio
  * use robustio in caching

Relates: #987, #994, #995, #1011
jirfag added a commit that referenced this issue May 3, 2020
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (`unused`). Clear it when it
becomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except `unused`.

Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4

Also in this commit:
  * speed up loading packages from export data (2.5s -> 2.1s for std)
    by not using mutex for export data since it was allowed in
    x/tools#07722704da13
  * make an order of execution of linters stable
  * update renameio and robustio
  * use robustio in caching

Relates: #987, #994, #995, #1011
jirfag added a commit that referenced this issue May 5, 2020
The primary improvement is in early clearing of
analyzed package's TypeInfo, facts, etc for
whole program analyzers (`unused`). Clear it when it
becomes unused and GC collects them early. Initially this
clearing was performed for all analyzers except `unused`.

Update staticcheck from v0.0.1-2019.2.3 to v0.0.1-2020.1.4

Also in this commit:
  * speed up loading packages from export data (2.5s -> 2.1s for std)
    by not using mutex for export data since it was allowed in
    x/tools#07722704da13
  * make an order of execution of linters stable
  * update renameio and robustio
  * use robustio in caching

Relates: #987, #994, #995, #1011
brimstone pushed a commit to storj/ci that referenced this issue Jun 3, 2020
https: //github.com/golangci/golangci-lint/issues/1011
Change-Id: I9156d152401cb1f9074a63c1a7859c72854fbd6c
@ldez ldez closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cursed This issue is doomed.
Projects
None yet
Development

No branches or pull requests

6 participants