Fetch support - merge pending upstream fetch and async reworks and add temporary workarounds #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpiderMonkey uses the `encoding_c` Rust crate and comes bundled with it. This lead to either duplication or linking errors when using our own crate re-exporting `encoding_c`. Instead, with this PR we just bundle a C header file for interacting with the crate's functionality, and rely on SpiderMonkey's version.
…eady been consumed
`HostString` converts to `string_view`, so this makes `decode` easy to use from more places.
…t API abstraction and various other fixes
…ring wizening The idea is that with this, builtins handling runtime events can dynamically load and execute a top-level script as needed. This functionality isn't actually used in this commit, but will be in another commit changing how incoming HTTP requests are handled.
Gets back to passing all current tests, and most of the WPT suite that Fastly's JS Compute runtime passes.
fix: release build
This changes the implementation of the handle abstraction to make it more robust, and cleans it up at least somewhat.
…ffer()`, or `.json()`
# Conflicts: # CMakeLists.txt # builtins/web/fetch/fetch_event.cpp # builtins/web/fetch/request-response.cpp
…o fetch # Conflicts: # builtins/web/fetch/request-response.cpp
…it can be made pollable on JS side) + debug logs
noise64
changed the title
vigoo
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Contains:
Note that the added tests are not passing with the http test server, only with the standalone module tests in ComponentizeJS (see the companion PR golemcloud/ComponentizeJS#2).
Added and exposed "runEventLoopUntilInterest" as a workaround until async support arrives, and also adjusted the interest increments and decrements until the above mentioned tests were passing without error logs.