Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model and build ILIs as distinct from lexicon #23

Closed
goodmami opened this issue Oct 26, 2020 · 2 comments
Closed

Model and build ILIs as distinct from lexicon #23

goodmami opened this issue Oct 26, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@goodmami
Copy link
Owner

goodmami commented Oct 26, 2020

Anticipating a future (the future is now) where we have a versioned release of CILI, I would like to build the ILI database from that release and not pieced together from individual wordnets. This is where the ILI definition data would come from, and when reading an LMF, the ILIs associated with synsets would only be checked for validation (e.g., that all declared ILIs exist in the ILI table, otherwise throw a warning and ignore them).

This would require the release data to be published in some way. See globalwordnet/cili#4

@goodmami goodmami added the enhancement New feature or request label Oct 26, 2020
@goodmami goodmami added this to the v0.5.0 milestone Dec 29, 2020
@goodmami goodmami mentioned this issue Jan 21, 2021
8 tasks
@goodmami goodmami modified the milestones: v0.5.0, v0.6.0 Jan 28, 2021
@goodmami
Copy link
Owner Author

goodmami commented Feb 2, 2021

In order to reduce friction a bit, instead of throwing warnings when ILIs are used and not in the database, we can provide some status of the ILI. If an ILI is loaded, the status comes authoritatively from the source (e.g., see globalwordnet/cili#8), but otherwise Wn can use the following:

  • presupposed (a synset has ili="i123" but i123 is not in the ILI table of the database)
  • proposed (a synset has ili="in"; a row will be inserted into the database, possibly with a definition from the WN-LMF file, but it won't have an ILI id)

For presupposed, later adding an ILI may change the status and definition if the ILI id is present. The latter would be removed if a lexicon is removed from the database, as it is tied to a single lexicon.

@goodmami goodmami changed the title Build ILI database separately Model and build ILIs as distinct from lexicon Feb 4, 2021
@goodmami
Copy link
Owner Author

goodmami commented Feb 4, 2021

I renamed this issue because it is now for a whole bunch of ILI changes:

  • Model ILI "objects" with id, definition, status, and metadata
  • Add methods ili() and ilis() for finding ILIs
  • Proposed ILIs are tied to a lexicon, regular ones are not

goodmami added a commit that referenced this issue Feb 10, 2021
goodmami added a commit that referenced this issue Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant