Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbortSignal support #144

Merged
merged 31 commits into from
Jul 22, 2024
Merged

AbortSignal support #144

merged 31 commits into from
Jul 22, 2024

Conversation

DellaBitta
Copy link
Collaborator

@DellaBitta DellaBitta commented May 20, 2024

Adds SingleRequestOptions with AbortSignal support to most of the asynchronous methods of:

  • GenerativeModel
  • GoogleAIFileManager
  • ChatSession

NOTE: AbortSignal is a client-only operation. Using it to cancel an operation will not cancel the request in the service. You will still be charged usage for any applicable operations.

Some methods are not supported as they would leave the server in an ambiguous state, namely GoogleAIFileManager.uploadFile() and GoogleAIFileManager.deleteFile().

packages/main/src/files/file-manager.ts Outdated Show resolved Hide resolved
packages/main/src/files/file-manager.ts Outdated Show resolved Hide resolved
packages/main/src/files/request.ts Outdated Show resolved Hide resolved
packages/main/test-integration/resources/cat.jpg Outdated Show resolved Hide resolved
packages/main/types/requests.ts Outdated Show resolved Hide resolved
import { GoogleAIFileManager } from "../../dist/files";

use(chaiAsPromised);

/**
* Integration tests against live backend.
*/
describe("abortSignal", function () {
describe("signal", function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to see if this works together with timeout (e.g., whichever comes first works)? Or if it's too hard to make an automated test, can you test it manually?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@gaodeng
Copy link

gaodeng commented Jul 6, 2024

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants