Skip to content

Commit

Permalink
Remove deprecated parameters from scripts.
Browse files Browse the repository at this point in the history
* Removed deprecated parameters from scripts.
* Expanded to use the more descriptive options in scripts.

PiperOrigin-RevId: 640582683
  • Loading branch information
michaelreneer authored and copybara-github committed Jun 5, 2024
1 parent 3fe9d4f commit e140192
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
5 changes: 1 addition & 4 deletions tools/python_package/build_python_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ main() {
while [[ "$#" -gt 0 ]]; do
option="$1"
case "${option}" in
--python=*)
shift
;;
--output_dir=*)
output_dir="${option#*=}"
shift
Expand Down Expand Up @@ -63,7 +60,7 @@ main() {
fi

# Create a temp directory.
local temp_dir="$(mktemp -d)"
local temp_dir="$(mktemp --directory)"
trap "rm -rf ${temp_dir}" EXIT

# Create a Python environment.
Expand Down
5 changes: 1 addition & 4 deletions tools/python_package/publish_python_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ main() {
while [[ "$#" -gt 0 ]]; do
option="$1"
case "${option}" in
--python=*)
shift
;;
--package=*)
package="${option#*=}"
shift
Expand Down Expand Up @@ -66,7 +63,7 @@ main() {
fi

# Create a temp directory.
local temp_dir="$(mktemp -d)"
local temp_dir="$(mktemp --directory)"
trap "rm -rf ${temp_dir}" EXIT

# Create a Python environment.
Expand Down
5 changes: 1 addition & 4 deletions tools/python_package/test_python_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ main() {
while [[ "$#" -gt 0 ]]; do
option="$1"
case "${option}" in
--python=*)
shift
;;
--package=*)
package="${option#*=}"
shift
Expand Down Expand Up @@ -66,7 +63,7 @@ main() {
fi

# Create a temp directory.
local temp_dir="$(mktemp -d)"
local temp_dir="$(mktemp --directory)"
trap "rm -rf ${temp_dir}" EXIT

# Create a Python environment.
Expand Down

0 comments on commit e140192

Please sign in to comment.