Enable live DASH stream for IMA DAI

This change enables the IMA extension to play live DASH streams with DAI support. Samples streams can be found and played in the main demo app. Issue: #10912 #minor-release PiperOrigin-RevId: 532407708 (cherry picked from commit 806f19c)
google · May 17, 2023 · 73b8233 · 73b8233
1 parent fcc11a0
commit 73b8233
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 18 deletions.
diff --git a/demos/main/src/main/assets/media.exolist.json b/demos/main/src/main/assets/media.exolist.json
@@ -406,6 +406,18 @@
         "name": "DASH VOD: Tears of Steel (11 periods, pre/mid/post), 2/5/2 ads [5/10s]",
         "uri": "ssai://dai.google.com/?contentSourceId=2559737&videoId=tos-dash&format=0&adsId=1"
       },
+      {
+        "name": "DASH live: Tears of Steel (mid), 3 ads each [10 s]",
+        "uri": "ssai://dai.google.com/?assetKey=jNVjPZwzSkyeGiaNQTPqiQ&format=0&adsId=1"
+      },
+      {
+        "name": "DASH live: New Tears of Steel (mid), 3 ads each [10 s]",
+        "uri": "ssai://dai.google.com/?assetKey=PSzZMzAkSXCmlJOWDmRj8Q&format=0&adsId=12"
+      },
+      {
+        "name": "DASH live: Unencrypted stream with 30s ad breaks every minute",
+        "uri": "ssai://dai.google.com/?assetKey=0ndl1dJcRmKDUPxTRjvdog&format=0&adsId=21"
+      },
       {
         "name": "Playlist: No ads - HLS VOD: Demo (skippable pre/post) - No ads",
         "playlist": [
@@ -434,20 +446,6 @@
           }
         ]
       },
-      {
-        "name": "Playlist: No ads - HLS Live: Big Buck Bunny (mid) - No ads",
-        "playlist": [
-          {
-            "uri": "https://html5demos.com/assets/dizzy.mp4"
-          },
-          {
-            "uri": "ssai://dai.google.com/?assetKey=sN_IYUG8STe1ZzhIIE_ksA&format=2&adsId=3"
-          },
-          {
-            "uri": "https://html5demos.com/assets/dizzy.mp4"
-          }
-        ]
-      },
       {
         "name": "Playlist: No ads - DASH VOD: Tears of Steel (11 periods, pre/mid/post) - No ads",
         "playlist": [

diff --git a/...c/main/java/com/google/android/exoplayer2/ext/ima/ImaServerSideAdInsertionUriBuilder.java b/...c/main/java/com/google/android/exoplayer2/ext/ima/ImaServerSideAdInsertionUriBuilder.java
@@ -379,10 +379,6 @@ public Uri build() {
     if (streamActivityMonitorId != null) {
       streamRequest.setStreamActivityMonitorId(streamActivityMonitorId);
     }
-    checkState(
-        streamRequest.getFormat() != StreamFormat.DASH
-            || TextUtils.isEmpty(streamRequest.getAssetKey()),
-        "DASH live streams are not supported yet.");
     return streamRequest;
   }
 }