Fix mediaMetadata being reset when media is repeated.

Issue: #9458 PiperOrigin-RevId: 399901865
google · Sep 30, 2021 · e335022 · e335022
1 parent 410ddf4
commit e335022
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -13,6 +13,8 @@
         `GlUtil.glAssertionsEnabled` instead.
     *   Move `Player.addListener(EventListener)` and
         `Player.removeListener(EventListener)` out of `Player` into subclasses.
+    *   Fix `mediaMetadata` being reset when media is
+        repeated ([#9458](https://github.com/google/ExoPlayer/issues/9458)).
 *   Video:
     *   Fix bug in `MediaCodecVideoRenderer` that resulted in re-using a
         released `Surface` when playing without an app-provided `Surface`

diff --git a/library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java b/library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImpl.java
@@ -1219,7 +1219,8 @@ private void updatePlaybackInfo(
       }
       newMediaMetadata = mediaItem != null ? mediaItem.mediaMetadata : MediaMetadata.EMPTY;
     }
-    if (!previousPlaybackInfo.staticMetadata.equals(newPlaybackInfo.staticMetadata)) {
+    if (mediaItemTransitioned
+        || !previousPlaybackInfo.staticMetadata.equals(newPlaybackInfo.staticMetadata)) {
       newMediaMetadata =
           newMediaMetadata.buildUpon().populateFromMetadata(newPlaybackInfo.staticMetadata).build();
     }