Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLS webVtt subtitle is out of sync on v2.1.0 #2208

Closed
ofuwape opened this issue Dec 16, 2016 · 2 comments
Closed

HLS webVtt subtitle is out of sync on v2.1.0 #2208

ofuwape opened this issue Dec 16, 2016 · 2 comments
Labels
bug

Comments

@ofuwape
Copy link

ofuwape commented Dec 16, 2016

Description
The HLS webvtt subtitle display is out of sync on v2.1.0 but plays fine on v1.5.13 and the Safari Browser.

Devices
I get this same issue on the following devices:

  • HTC Nexus 9 (Android 7.0 API 24) {Real Device}
  • Nexus 6 (Android 7.0 API 24) {Virtual Device}
  • Nexus 6 (Android 6.0 API 23) {Virtual Device}

Video URL: https://cdn.curiositystream.com/system/Encoding/HW/000/000/685/670/storyhouse_insidethearizona_rev3_preview-3ea65eb4706954bfe635f261c129a4dd41f92dbb_v2.m3u8
@ojw28 ojw28 added the bug label Dec 16, 2016
@ojw28
Copy link
Contributor

ojw28 commented Dec 16, 2016 •
edited
Loading

We'll merge a fix for this shortly, thanks!

ojw28 added a commit that referenced this issue Dec 16, 2016
@ojw28
Correctly offset subsample timestamps.
e0586a4 
This has always been broken in V2, but the issue is now also
visible for the very first period in the timeline because we
offset if by 60s. Previously the issue would only have been
visible from the start of the second period.

Issue: #2208

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=142252702
@ojw28
Copy link
Contributor

ojw28 commented Dec 16, 2016

This is fixed on dev-v2. We will likely do a bug-fix-only 2.1.1 release next week.

@ojw28 ojw28 closed this as completed Dec 16, 2016
ojw28 added a commit that referenced this issue Dec 20, 2016
@ojw28
Correctly offset subsample timestamps.
ada19a2 
This has always been broken in V2, but the issue is now also
visible for the very first period in the timeline because we
offset if by 60s. Previously the issue would only have been
visible from the start of the second period.

Issue: #2208

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=142252702
@ojw28 ojw28 mentioned this issue Dec 20, 2016
Closed
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofuwape @ojw28