Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

608 captions will not appear without seeking back #3250

Closed
sergiomartinez4 opened this issue Sep 7, 2017 · 4 comments
Closed

608 captions will not appear without seeking back #3250

sergiomartinez4 opened this issue Sep 7, 2017 · 4 comments
Assignees
Labels

Comments

@sergiomartinez4
Copy link

Issue description

After I load the video with 608 captions and select the right text track, the captions will not show. I need to seek back (before completing the video playback) in order for the captions to appear.

The expected behavior is that the 608 captions must always appear when they're enabled.

Reproduction steps

I added the below HLS video to the Demo Samples using the latest ExoPlayer version 2.5.1.
The video has 608 captions, and you can see them at ~2 seconds, ~8 seconds and ~9 seconds.

Steps

  1. Load the Demo app and select the video
  2. Enable text track with 608 captions.
  3. Let it play and watch for any text tracks (no text tracks will appear).
  4. At this point, you can also wait until the end of the video and seek all the way to the beginning and repeat step 3. You will not see any caption.

There are some steps I follow to make the captions to appear.

  1. Load the Demo app and select the video
  2. Enable text track with 608 captions.
  3. Let it play for a couple of seconds (or anytime before the video completes) and seek back to the beginning.
  4. Let it play and you will see the captions at ~2 seconds, ~8 seconds and ~9 seconds.

Link to test content

http://solutions.brightcove.com/jwhisenant/hls/608_exoplayer_captions_issue/bipbop/bipbop_4x3_variant_1seg.m3u8

Version of ExoPlayer being used

ExoPlayer version used: 2.5.1

Device(s) and version(s) of Android being used

Tested with Google Pixel with Android 7.1.2

A full bug report captured from the device

Bug report:
bugreport-NJH47F-2017-09-07-16-45-03.zip

@sergiomartinez4
Copy link
Author

are there any news about possible causes?

@AquilesCanta AquilesCanta self-assigned this Sep 11, 2017
@AquilesCanta
Copy link
Contributor

I'll have a look.

ojw28 pushed a commit that referenced this issue Sep 19, 2017
1- Avoid dropped buffers by using a PriorityQueue instead of a set.
2- Process the end of stream after non-EOS buffers.

Issue:#3250

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169077365
@ojw28
Copy link
Contributor

ojw28 commented Sep 19, 2017

This is fixed in dev-v2, and will be in r2.5.3, which will be released some time this week.

@ojw28 ojw28 closed this as completed Sep 19, 2017
@sergiomartinez4
Copy link
Author

Awesome, thanks!

ojw28 pushed a commit that referenced this issue Sep 19, 2017
1- Avoid dropped buffers by using a PriorityQueue instead of a set.
2- Process the end of stream after non-EOS buffers.

Issue:#3250

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169077365
ojw28 pushed a commit that referenced this issue Sep 20, 2017
1- Avoid dropped buffers by using a PriorityQueue instead of a set.
2- Process the end of stream after non-EOS buffers.

Issue:#3250

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169077365
@google google locked and limited conversation to collaborators Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants