Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMA extension: Support playback of HLS ads #3302

Closed
jeevarajp opened this issue Sep 27, 2017 · 10 comments
Closed

IMA extension: Support playback of HLS ads #3302

jeevarajp opened this issue Sep 27, 2017 · 10 comments
Assignees

Comments

@jeevarajp
Copy link

jeevarajp commented Sep 27, 2017

I am using exoplayer version 2.5.3

I followed exactly same steps in https://medium.com/google-exoplayer/playing-ads-with-exoplayer-and-ima-868dfd767ea blog and was able to play mp4 ads. But I am unable to play HLS ads using exoplayer ima extension 2.5.3.

Please advise me whether this ima extension (2.5.3) has HLS ad support or not. If yes, what am I doing wrong? If no, please advise any alternative way for achieving it.

Thanks.

@andrewlewis
Copy link
Collaborator

It should work. What goes wrong when you try to insert ads with an HlsMediaSource as the content media source?

@jeevarajp
Copy link
Author

jeevarajp commented Sep 27, 2017

Yes, I am able to play HLS content (using HlsMediaSource). But HLS advertisements are not playing for me (mp4 advertisement plays).

@andrewlewis
Copy link
Collaborator

We assume the ad media URIs provided by the IMA SDK are all playable with ExtractorMediaSource at the moment, so this isn't supported.

Please could you provide the ad tag you're trying to play here, or email it to dev.exoplayer@gmail.com, then we can take a look? It's probably fairly straightforward to make this work if IMA supports it. Thanks.

@jeevarajp
Copy link
Author

jeevarajp commented Sep 27, 2017

Below is the ad tag I am trying to play.

<VAST version="2.0"><Ad id="1"><InLine><AdSystem/><AdTitle/><Impression>../static/clear_dot.gif?impression</Impression><Creatives><Creative><Linear skipoffset="00:00:08"><Duration>00:00:30</Duration><MediaFiles><MediaFile delivery="progressive" type="application/x-mpegURL" scalable="true" width="" height="">https://www.outsourcelive.com/vast/advertisement_hls/Amazon_hls/amaz.m3u8</MediaFile></MediaFiles><TrackingEvents><Tracking event="creativeView">../static/clear_dot.gif?createView</Tracking><Tracking event="start">../static/clear_dot.gif?start</Tracking><Tracking event="firstQuartile">../static/clear_dot.gif?firstQuartile</Tracking><Tracking event="midpoint">../static/clear_dot.gif?midpoint</Tracking><Tracking event="thirdQuartile">../static/clear_dot.gif?thirdQuartile</Tracking><Tracking event="complete">../static/clear_dot.gif?complete</Tracking><Tracking event="skip">../static/clear_dot.gif?skip</Tracking><Tracking event="mute">../static/clear_dot.gif?mute</Tracking><Tracking event="unmute">../static/clear_dot.gif?unmute</Tracking><Tracking event="pause">../static/clear_dot.gif?pause</Tracking><Tracking event="rewind">../static/clear_dot.gif?rewind</Tracking><Tracking event="resume">../static/clear_dot.gif?resume</Tracking><Tracking event="fullscreen">../static/clear_dot.gif?fullscreen</Tracking><Tracking event="expand">../static/clear_dot.gif?expand</Tracking><Tracking event="collapse">../static/clear_dot.gif?collapse</Tracking><Tracking event="acceptInvitation">../static/clear_dot.gif?acceptInvitation</Tracking><Tracking event="close">../static/clear_dot.gif?close</Tracking></TrackingEvents><VideoClicks><ClickThrough> http://ya.ru/ </ClickThrough><ClickTracking> ../static/clear_dot.gif?click </ClickTracking></VideoClicks></Linear></Creative></Creatives></InLine></Ad></VAST>

@ojw28 ojw28 changed the title IMA extension: unable to play HLS ads IMA extension: Support playback of HLS ads Oct 2, 2017
@jeevarajp
Copy link
Author

jeevarajp commented Oct 3, 2017

So Exoplayer IMA extension v2.5.3 doesn't have support for playback of HLS ads right now?

Is it possible to me to set AdsRenderingSettings mimetype as mentioned here in this post and add HLS ads support to IMA extension?

When can I expect HLS ads support? Please advise.

@andrewlewis
Copy link
Collaborator

Correct. We don't support this right now.

To implement it, we need to create the right type of media source in AdsMediaSource, and also handle media sources that don't allow immediate creation of a period. No promises when it will be done, but I expect we can push a change to support this during the new few weeks.

@andrewlewis andrewlewis self-assigned this Oct 3, 2017
@rjlevesque
Copy link

Hi @andrewlewis, sorry to be a pest but any updates on HLS ad support?

@andrewlewis
Copy link
Collaborator

@rjlevesque No updates yet I'm afraid.

ojw28 pushed a commit that referenced this issue Dec 12, 2017
Issue: #3302

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178615074
@ojw28 ojw28 closed this as completed Dec 12, 2017
ojw28 pushed a commit that referenced this issue Dec 12, 2017
Issue: #3302

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178615074
@jeevarajp
Copy link
Author

@ojw28 / @andrewlewis could you please let me know release version of exoplayer which includes this feature?

@andrewlewis
Copy link
Collaborator

Please try it out on the release candidate branch dev-v2-r2.6.1 and let us know if you have any problems. Thanks!

@google google locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants