Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLAC Extension doesn't play high sample rate files (for example 192khz) #3769

Closed
Denis55ka opened this issue Jan 30, 2018 · 3 comments
Closed

FLAC Extension doesn't play high sample rate files (for example 192khz) #3769

Denis55ka opened this issue Jan 30, 2018 · 3 comments
Assignees
@botaydotcom
Labels
enhancement

Comments

@Denis55ka
Copy link

Denis55ka commented Jan 30, 2018 •
edited
Loading

Issue description

FLAC Extension doesn't play audio with high sample rate (for example 192khz). It throws with exception E/FLACParser: unsupported sample rate 192000

Version of ExoPlayer being used

2.6.1

Device(s) and version(s) of Android being used

Xiaomi Mi5

A full bug report captured from the device

E/FLACParser: unsupported sample rate 192000
E/FLACParser: unsupported sample rate 192000
E/ExoPlayerImplInternal: Source error.
java.io.IOException: Metadata decoding failed
at com.google.android.exoplayer2.ext.flac.FlacExtractor.read(FlacExtractor.java:98)
at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractingLoadable.load(ExtractorMediaPeriod.java:749)
at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:315)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:760)
@Denis55ka Denis55ka changed the title FLAC Extension doesn't play high sample rate files (for exemple 192khz) FLAC Extension doesn't play high sample rate files (for example 192khz) Jan 30, 2018
@erdemguven erdemguven self-assigned this Jan 30, 2018
@erdemguven
Copy link
Contributor

Thanks for reporting this. I'll look into this but not likely to be soon.

@marverenic marverenic mentioned this issue Mar 30, 2018
Closed
@ojw28 ojw28 assigned botaydotcom and unassigned erdemguven Apr 11, 2018
@ojw28
Copy link
Contributor

ojw28 commented Apr 11, 2018

@botaydotcom - This looks extractor related (probably just need to add support for the extra sample rate).

ojw28 pushed a commit that referenced this issue Apr 16, 2018
@botaydotcom @ojw28
Supports FLAC files with high sample rate (176400 and 192000).
0b08688 
Also add testing media to verify FLAC extension can play these sample rates.

Github: #3769.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=192783193
@botaydotcom
Copy link
Contributor

This issue is fixed in the referenced commit. Please help us to check whether it works for you using the dev-v2 branch.

@google google locked and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@botaydotcom botaydotcom

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@botaydotcom @ojw28 @Denis55ka @erdemguven