ConcatMediaSource is failing to restore when ClippingMediaSource is used. #5351
Assignees
Labels
Comments
|
@ojw28 Could you please check this issue? |
|
Thanks for reporting. We'll provide a fix soon. |
ojw28
pushed a commit
that referenced
this issue
Jan 14, 2019
We currently forget whether a source is seekable at re-preparation. This was implemented intentionally this way under the assumption that we really can't seek until we have loaded the seek map again. However, seek operations are only allowed after a media period is prepared. So there is no harm in remembering whether a source is seekable. This problem currently prevents reusing ClippingMediaSources with ExtractorMediaSource and a non-zero start clip position. Issue: #5351 PiperOrigin-RevId: 229169441
ojw28
pushed a commit
that referenced
this issue
Jan 15, 2019
We currently forget whether a source is seekable at re-preparation. This was implemented intentionally this way under the assumption that we really can't seek until we have loaded the seek map again. However, seek operations are only allowed after a media period is prepared. So there is no harm in remembering whether a source is seekable. This problem currently prevents reusing ClippingMediaSources with ExtractorMediaSource and a non-zero start clip position. Issue: #5351 PiperOrigin-RevId: 229169441
|
Closing as fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reproduction steps
1 . Create a ConcatMediaSource with ClippingMediaSource.
2. Play content using above mediaSource.
3. Do
player.stop(false)4. Restore above player instance using
player.prepare(mediaSource, false, false).5. Observation media doesn't restore
Probable fix -
listenerNotificationScheduled = false;inreleaseSourceInternalofConcatenatingMediaSourceThe text was updated successfully, but these errors were encountered: