Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmoothStreaming TTML fMP4 crashes player #5378

Closed
icetronics opened this issue Jan 14, 2019 · 6 comments
Closed

SmoothStreaming TTML fMP4 crashes player #5378

icetronics opened this issue Jan 14, 2019 · 6 comments
Assignees
Labels

Comments

@icetronics
Copy link

Issue description

After enabling the subtitle track during encrypted playback, the player crashes.
Setup: SmoothStreaming with PlayReady DRM, TTML in fMP4 (not encrypted)
Comparison: DRM-free SmoothStr with same subtitle setup plays flawlessly.

Link to test content

Manifest URL sent via email.
Might not be possible to play as the DRM license request requires a special header which includes an OAuth token that expires after a time.

Version of ExoPlayer being used

2.9.2

Device(s) and version(s) of Android being used

FireTV (any generation)
FireOS 5.2.6.8

A full bug report captured from the device

Sent via email.

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.google.android.exoplayer2.util.ParsableByteArray.readBytes(byte[], int, int)' on a null object reference
        at com.google.android.exoplayer2.source.SampleQueue.sampleData(SampleQueue.java:561)
        at com.google.android.exoplayer2.source.chunk.ChunkExtractorWrapper$BindingTrackOutput.sampleData(ChunkExtractorWrapper.java:206)
@ojw28 ojw28 self-assigned this Jan 14, 2019
@ojw28 ojw28 added the bug label Jan 14, 2019
@ojw28
Copy link
Contributor

ojw28 commented Jan 14, 2019

This is related to confusion around how subtitles are handled in DRM protected SmoothStreaming. An attempt was made to assume they're always unprotected in #4838 (which is the case in the sample provided). But it looks like the solution for doing so wasn't quite complete. It's easy to fix; we'll use this issue for tracking.

ojw28 added a commit that referenced this issue Jan 14, 2019
Issue: #5378
PiperOrigin-RevId: 229261658
@ojw28
Copy link
Contributor

ojw28 commented Jan 14, 2019

Fixed in dev-v2. Please verify if you have a chance.

@ojw28 ojw28 closed this as completed Jan 14, 2019
@icetronics
Copy link
Author

Thanks a lot for the quick action, @ojw28! I'll try to verify it this week and get back to you. Can you please forecast which version could incorporate this fix?

@ojw28
Copy link
Contributor

ojw28 commented Jan 15, 2019

It'll be in 2.9.4.

ojw28 added a commit that referenced this issue Jan 15, 2019
Issue: #5378
PiperOrigin-RevId: 229261658
@icetronics
Copy link
Author

Hi @ojw28, just came back to let you know that your fix is working marvelously. Many thanks for the prompt action!

@ojw28
Copy link
Contributor

ojw28 commented Jan 24, 2019

Glad to hear it; thanks for confirming!

@google google locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants