Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upstream discard to HLS #6322

Closed
stevemayhew opened this issue Aug 20, 2019 · 5 comments
Closed

Add support for upstream discard to HLS #6322

stevemayhew opened this issue Aug 20, 2019 · 5 comments
Assignees

Comments

@stevemayhew
Copy link
Contributor

Use case description

It is undesirable to leave poor quality buffered video samples in place when sufficient higher quality samples exist to replace them.

Two cases this can happen:

  1. Adaptation in live playlists can leave substantial low quality data buffered, particularly in the channel change case where low bit rate initial selection facilitates rapid channel change.
  2. When switching from trick-play (low frame rate) tracks to regular frame rate.

Proposed solution

Implement the existing SequenceableLoader#reevaluateBuffer() method in library-hls.

The work on this is in a pending pull request #6321

Alternatives considered

Using a separate SampleStreamWrapper and TrackGroup for the trick-play tracks. The more elegant solution of including these tracks with the balance of the adaptation set necessitates this.

@tonihei
Copy link
Collaborator

tonihei commented Aug 20, 2019

Thanks for filing the tracking issue. Can you let us know when #6321 is ready for review?

@stevemayhew
Copy link
Contributor Author

stevemayhew commented Aug 20, 2019 via email

@ojw28
Copy link
Contributor

ojw28 commented Aug 29, 2019

If I remember correctly, it's also nastier because there's no guarantee that segments are aligned across variants, or (in the case of TS) that they start with a keyframe.

@stevemayhew
Copy link
Contributor Author

Probably best to restrict this to playlists that indicate EXT-X-INDEPENDENT-SEGMENTS then.

@tonihei
Copy link
Collaborator

tonihei commented May 21, 2020

This is now supported with PR #7244.

@tonihei tonihei closed this as completed May 21, 2020
@google google locked and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants