Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultTimeBar Android 10 - back gesture handling #6685

Closed
curlyfrie opened this issue Nov 22, 2019 · 2 comments
Closed

DefaultTimeBar Android 10 - back gesture handling #6685

curlyfrie opened this issue Nov 22, 2019 · 2 comments
Assignees
@ojw28
Labels
enhancement

Comments

@curlyfrie
Copy link

curlyfrie commented Nov 22, 2019 •
edited
Loading

Use case description

Android 10 with navigation gestures

Timebar is edge to edge, user wants to move the thumb from the begin to the middle => back gesture triggered. wanted => seek

Proposed solution

implement setSystemGestureExclusionRects()
https://developer.android.com/guide/navigation/gesturenav#back-gestures

Since the "SeekBar components support automatic opt-out behavior out of the box." I think it would be a good idea to also support this.
@icbaker
Copy link
Collaborator

icbaker commented Nov 25, 2019

Thanks for the suggestion! I'll take a look.

@icbaker icbaker self-assigned this Nov 25, 2019
@ojw28 ojw28 assigned ojw28 and unassigned icbaker Dec 10, 2019
ojw28 added a commit that referenced this issue Dec 10, 2019
@ojw28
Make DefaultTimeBar exclude itself for gestures
90329a1 
Issue: #6685
PiperOrigin-RevId: 284736041
@ojw28 ojw28 closed this as completed Dec 10, 2019
@curlyfrie
Copy link
Author

Nice, thx :)

ojw28 added a commit that referenced this issue Dec 19, 2019
@ojw28
Make DefaultTimeBar exclude itself for gestures
5bead4a 
Issue: #6685
PiperOrigin-RevId: 284736041
@google google locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icbaker @ojw28 @curlyfrie