Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add VideoAdPlayerCallback to ImaAdsLoader in latest version 2.12.0 #7944

Closed
Manvendra-Jadon opened this issue Sep 18, 2020 · 6 comments
Assignees
Labels

Comments

@Manvendra-Jadon
Copy link

Manvendra-Jadon commented Sep 18, 2020

I am getting an error, where video force closes before playing mid-roll ad. Here is the stack trace for the same:

E/ImaAdsLoader: Internal error in loadAd
java.lang.IllegalStateException: Failed to find cue point
at com.google.android.exoplayer2.ext.ima.ImaAdsLoader.getAdGroupIndexForAdPod(ImaAdsLoader.java:1457)
at com.google.android.exoplayer2.ext.ima.ImaAdsLoader.loadAd(ImaAdsLoader.java:845)
at com.google.ads.interactivemedia.v3.internal.akf.a(IMASDK:23)
at com.google.ads.interactivemedia.v3.internal.akb.a(IMASDK:177)
at com.google.ads.interactivemedia.v3.internal.akb.a(IMASDK:44)
at com.google.ads.interactivemedia.v3.internal.ake.b(IMASDK:28)
at com.google.ads.interactivemedia.v3.internal.akc.shouldOverrideUrlLoading(IMASDK:6)
at org.chromium.android_webview.AwContentsClientBridge.shouldOverrideUrlLoading(AwContentsClientBridge.java:17)
at android.os.MessageQueue.nativePollOnce(Native Method)
at android.os.MessageQueue.next(MessageQueue.java:143)
at android.os.Looper.loop(Looper.java:122)
at android.app.ActivityThread.main(ActivityThread.java:5597)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:984)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

I tried upgrading ima extension to latest version, but i am unable to add callback, which is required on my end.

@andrewlewis
Copy link
Collaborator

Please could you share the ad tag here or email it to dev.exoplayer@gmail.com with subject "#7944"? Thanks.

@Manvendra-Jadon
Copy link
Author

@andrewlewis Details sent through email(dev.exoplayer@gmail.com).

@andrewlewis
Copy link
Collaborator

I tried upgrading ima extension to latest version, but i am unable to add callback, which is required on my end.

On the latest version I can't reproduce the problem (the ad tag has two empty ads with cue points "0" and "-1" (postroll) but both are located correctly).

Could you give some more details about what information you need from VideoAdPlayerCallback? The same information should be available via player listeners, so there may be an alternative way to implement what you're trying to do.

@Manvendra-Jadon
Copy link
Author

Manvendra-Jadon commented Sep 28, 2020

Screenshot 2020-09-28 at 4 46 13 PM

@andrewlewis If you see screenshot, when i am upgrading from 2.11.5 to 2.12.0, i am not able to add this callback showing in red. Because of this i am unable to check anything on latest version.

Also, stack-trace mentioned in the bug: #7322
is the same i get when video force closes before playing mid-roll.

@andrewlewis
Copy link
Collaborator

What events to do you handle in your VideoAdPlayerCallback? I am wondering if you can replace those with listening to events on the player to avoid needing to add a callback. See also #6249.

@Manvendra-Jadon
Copy link
Author

@andrewlewis We handle onPlay(), onEnded(), onError(). Is there no way to add this callback on latest version? As this is lot of effort on my end to change this and will surely break few things.

Also, what about this:
Stack-trace mentioned in the bug: #7322
is the same i get when video force closes before playing mid-roll.

kim-vde pushed a commit that referenced this issue Oct 6, 2020
Issue: #7944
PiperOrigin-RevId: 335012643
@ojw28 ojw28 closed this as completed Oct 11, 2020
ojw28 pushed a commit that referenced this issue Oct 21, 2020
Issue: #7944
PiperOrigin-RevId: 335012643
@google google locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants