RtspMediaTrack absolute path (URI) for track

[a-blekot]

public RtspMediaTrack(MediaDescription mediaDescription, Uri sessionUri) {
    checkArgument(mediaDescription.attributes.containsKey(ATTR_CONTROL));
    payloadFormat = generatePayloadFormat(mediaDescription);
    uri =
        sessionUri
            .buildUpon()
            .appendEncodedPath(castNonNull(mediaDescription.attributes.get(ATTR_CONTROL)))
            .build();
  }

If mediaDescription.attributes.get(ATTR_CONTROL) - returns absolute path (started with rtsp://) we have invalid path.

So, I have made little checking to handle this case:

  public RtspMediaTrack(MediaDescription mediaDescription, Uri sessionUri) {
    checkArgument(mediaDescription.attributes.containsKey(ATTR_CONTROL));
    payloadFormat = generatePayloadFormat(mediaDescription);
    uri = absoluteUri(sessionUri, castNonNull(mediaDescription.attributes.get(ATTR_CONTROL)));
  }

  private static Uri absoluteUri(Uri sessionUri, String trackId) {
    if (trackId.startsWith("rtsp://") || trackId.startsWith("rtsps://")) {
      return Uri.parse(trackId);
    } else {
      return sessionUri
          .buildUpon()
          .appendEncodedPath(trackId)
          .build();
    }
  }

[claincly]

It seems your camera is not accepting a URL. Or your control attribute contains an rtsp:// prefix?

[claincly]

We will have a fix for this, thanks for pointing out!

[a-blekot]

Yes, our control attribute has an absolute path (starts with rtsp://123.123.....)
Again I'm not sure, maybe our camera responses implementation does not follow RTSP standards...

[claincly]

The use of absolute paths is in the RFC, so we should support it. The fix is on the way.

…

On Tue, Jul 13, 2021 at 8:07 PM Aleksey Blekot ***@***.***> wrote: Yes, our control attribute has an absolute path (starts with rtsp://123.123.....) Again I'm not sure, maybe our camera responses implementation does not follow RTSP standards... — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUCMUUS4R5WG5HJZZOTPBWTTXSFHRANCNFSM5AG6KJ2A> .