-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalize first letter of a text in track selector menu items #9452
Comments
This is the string returned by |
I think |
Locale names are "title cased" at least in the platform Settings app. This is what it uses internally: https://android.googlesource.com/platform/frameworks/base.git/+/refs/tags/android-11.0.0_r45/core/java/com/android/internal/app/LocaleHelper.java#68 |
Thanks for the pointer! |
Issue: #9452 PiperOrigin-RevId: 400680794
*** Original commit *** Fix capitalization of language in track selector Issue: #9452 *** PiperOrigin-RevId: 400706984
This is fixed by the three commits ref'd above (the second is a rollback, and third is a roll forward that includes a fix for the initial commit). |
This is how the audio selector of
StyledPlayerView
looks like in two languages (English and Czech):In Czech (and other languages probably as well), the language name (
angličtina
) is in all lower case characters. But because of the use in this menu, I think the first letter should be upper cased in DefaultTrackNameProvider.buildLanguageOrLabelString().The text was updated successfully, but these errors were encountered: