Fix possible subrip timing line NPE #3185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a possible NPE when reading the subrips timing line. We've had this occur for multiple users. Most likely due to corrupt srts, but would prefer the subs to just not appear in this scenario.
Not sure of your style guide (re: ternary operators), but figured it was tidier to reuse the "matches" check as in both scenarios the timing line is "invalid".
Error seen in the wild (trimmed) is: