Add a test for Gradle incremental compilation with AutoValue. #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pointer! That tells me what I had already discovered, that the Gradle installation directory is |
tbroyer
approved these changes
Apr 19, 2021
Comment on lines
+93
to
+98
| <dependency> | ||
| <groupId>dev.gradleplugins</groupId> | ||
| <artifactId>gradle-test-kit</artifactId> | ||
| <version>6.8.3</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Hey, didn't know about these redistributions (by former Gradle, Inc. employees), this is great!
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
cgdecker
requested changes
Apr 21, 2021
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
cgdecker
requested changes
Apr 21, 2021
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
eamonnmcmanus
commented
Apr 21, 2021
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
cgdecker
reviewed
Apr 21, 2021
value/src/it/functional/src/test/java/com/google/auto/value/GradleTest.java
Outdated
Show resolved
Hide resolved
cgdecker
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1075. Still need a test for AutoFactory.
Many thanks to @tbroyer for help developing this.