Added input and output graph lists. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xllora
requested changes
Jun 14, 2017
bql/grammar/grammar_test.go
Outdated
| func TestAcceptDeleteDataFromGraphOpsByParseAndSemantic(t *testing.T) { | ||
| table := []struct { | ||
| query string | ||
| graphs int |
There was a problem hiding this comment.
I'd rather suggest to use []string{"?graph",...} instead of testing for length. Here and on the other tests. Since this aso improves on correctness.
There was a problem hiding this comment.
Done. Also added tests for the construct statement.
|
PTAL, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add input and output graph lists to the statement, along with the regular graph lists. The idea is to use the regular graph lists to collect graphs for creation/deletion, and the input graph lists to collect graphs that act as a source of information (such as information queried in a WHERE clause) and the output graph lists to collect graphs that act as a destination of information (such as triples added in an INSERT or CONSTRUCT clause).
There are a couple of reasons for this change. Primarily, there needs to be a distinction between input and output graphs in a CONSTRUCT...WHERE BQL statement. Also, having the distinction helps to reason through the code.