Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized Reification Clauses into Predicate-Object Pairs. #77

Merged
merged 2 commits into from
Jul 16, 2017
Merged

Generalized Reification Clauses into Predicate-Object Pairs. #77

merged 2 commits into from
Jul 16, 2017

Conversation

apr94
Copy link
Contributor

@apr94 apr94 commented Jul 10, 2017

Also cleaned up some test formatting. Mostly, this PR gets rid of massive amounts of duplicated code implementing the CONSTRUCT clause.

@apr94 apr94 force-pushed the refactor_struct branch 2 times, most recently from dc0f5c3 to 5e75af4 Compare July 10, 2017 07:00
xllora
xllora approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@xllora xllora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the refactor

@xllora xllora closed this Jul 16, 2017
@xllora xllora reopened this Jul 16, 2017
@xllora xllora closed this Jul 16, 2017
@xllora xllora reopened this Jul 16, 2017
@xllora xllora merged commit e141044 into google:master Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xllora xllora xllora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apr94 @xllora