Dry Run Argument #1844
Closed
Dry Run Argument #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time, min warmup time
…istry/benchmark into feature/dry-run-argument
dmah42
reviewed
Aug 23, 2024
dmah42
reviewed
Aug 23, 2024
dmah42
reviewed
Aug 23, 2024
|
i tried to make some changes and commit here but it didn't work so they're in #1851. @Shaan-Mistry would you like to make the same changes in your PR and merge them here or are you ok with me merging #1851 (you still get commits in your name .. i don't want to take away from your work). |
|
merging #1851 is good with me! |
|
merged as #1851 .. thank you so much, @Shaan-Mistry ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the functionality for a dry run benchmark called through the cli argument --benchmark_dry_run.
Changes
Please let me know if I need to make any change I will be happy to implement them!