Mock default enabling recursive planning for identifying compatibility issues. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_623213699
branch
7 times, most recently
from
22a299d
to
38e0a1c
Compare
…y issues. Do not merge. PiperOrigin-RevId: 623213699
copybara-service
bot
force-pushed
the
test_623213699
branch
from
38e0a1c
to
bebd2dd
Compare
| @@ -991,6 +1404,18 @@ class FlatExprVisitor : public cel::ast_internal::AstVisitor { | |||
| } | |||
| } | |||
|
|
|||
| void SetRecursiveStep(std::unique_ptr<DirectExpressionStep> step, int depth) { | |||
| if (!progress_status_.ok() || PlanningSuppressed()) { | |||
There was a problem hiding this comment.
What happens if planning is suppressed and this call is encountered. I would think that normally we wouldn't get here.
There was a problem hiding this comment.
It would just ignore the recursive step argument (so it just gets freed when the caller returns). The program builder will still build up the ast structure, but it won't have any program steps associated with it.
This is only really applies for bind expressions -- we still traverse the iter_range and condition subexpressions, but just ignore any of the program steps that the visitor emits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock default enabling recursive planning for identifying compatibility issues.
Do not merge.