error-handling: split thiserror into its own slide #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw-immunant
force-pushed
the
fw/error-crates-split
branch
from
bc85368
to
a1b377d
Compare
mgeisler
reviewed
Sep 2, 2024
randomPoison
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Excellent, I've been meaning to do this forever. Changes look good, modulo @mgeisler's outstanding requets.
fw-immunant
force-pushed
the
fw/error-crates-split
branch
3 times, most recently
from
e6b58db
to
45f240b
Compare
`thiserror` is best understood as a way to eliminate boilerplate on the patterns we've already seen, and then we can show it in conjunction with `anyhow` subsequently.
fw-immunant
force-pushed
the
fw/error-crates-split
branch
from
45f240b
to
56f20dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thiserroris best understood as a way to eliminate boilerplate on the patterns we've already seen, and then we can show it in conjunction withanyhowsubsequently.Fixes #2027.