Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove part about Error not being no_std #2369

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove part about Error not being no_std #2369

merged 1 commit into from
Sep 18, 2024

Conversation

mgeisler
Copy link
Collaborator

This reverts #1005 now that Rust 1.81 has stabilized the Error trait.

@mgeisler
Copy link
Collaborator Author

@domenukk, should the slide refer to core::error::Error instead?

@mgeisler mgeisler mentioned this pull request Sep 17, 2024
Merged
randomPoison
randomPoison approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it's best to refer to std::error::Error, I think it's simpler to just tell students it's part of the standard library without going into the nuances of core vs std.

@mgeisler mgeisler merged commit 7a6abee into main Sep 18, 2024
37 checks passed
@mgeisler mgeisler deleted the mgeisler-patch-2 branch September 18, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomPoison randomPoison randomPoison approved these changes

@domenukk domenukk Awaiting requested review from domenukk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgeisler @randomPoison