Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uk: Refresh translations #2375

Merged
merged 1 commit into from
Sep 29, 2024
Merged

uk: Refresh translations #2375

merged 1 commit into from
Sep 29, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Sep 21, 2024

uk: Refresh translations

mdbook build
msgmerge --update po/uk.po book/xgettext/messages.pot

Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta
Copy link
Contributor Author

reta commented Sep 23, 2024

Thanks @dyeroshenko , I think the msgid check is expected to fail since it is merge with recent content. Thanks again!

@mgeisler
Copy link
Collaborator

Yeah, thanks so much for these updates!

I think the msgid check is expected to fail since it is merge with recent content. Thanks again!

Actually, the check is based on the POT-Creation-Date header: if this field is unchanged, then the msgid fields must all be unchanged too. The goal was to avoid having people edit the auto-generated msgid fields (since doing so would have no effect). The test is green now, so I think this was done correctly.

Running dprint fmt on my system fixes the formatting complains from the other CI check. It also produces changes in pl.po and de.po, which is weird... that is #2173, which I still don't know what to do about.

One small thing you can do at some point would be update version of mdbook-i18n-helpers used. I think you're using an old version since I see line numbers for the files outside of SUMMARY.md:

-#: src/SUMMARY.md
-msgid "Slices: `&[T]`"
-msgstr "Зрізи: `&[T]`"
+#: src/SUMMARY.md src/references/slices.md:5
+msgid "Slices"
+msgstr "Зрізи"

The granularity setting in book.toml ought to prevent this:

[output.xgettext]
optional = true
pot-file = "messages.pot"
granularity = 0

If not, then something is broken somewhere 😄

@reta
Copy link
Contributor Author

reta commented Sep 27, 2024

Actually, the check is based on the POT-Creation-Date header: if this field is unchanged, then the msgid fields must all be unchanged too.

Thanks @mgeisler this field is actually changed:

- "POT-Creation-Date: 2024-06-27T18:39:25-04:00\n"
+ "POT-Creation-Date: 2024-09-21T12:49:47-04:00\n"

@mgeisler
Copy link
Collaborator

Actually, the check is based on the POT-Creation-Date header: if this field is unchanged, then the msgid fields must all be unchanged too.

Thanks @mgeisler this field is actually changed:

- "POT-Creation-Date: 2024-06-27T18:39:25-04:00\n"
+ "POT-Creation-Date: 2024-09-21T12:49:47-04:00\n"

Yeah, that must be why the "Prevent unintended msgid changes / check-msgid-changes" check passes. The "Test / format" should be gone now that @djmitche created #2381 — so this is ready to merge.

@mgeisler mgeisler merged commit 0fe2722 into google:main Sep 29, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants