copy languages for conformance parser #8174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaileychess
approved these changes
Nov 26, 2023
candysonya
pushed a commit
to candysonya/flatbuffers
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to address failing conformance when advanced features are used (#8169)
I put copying only languages that are used instead of copying all options as they might not be needed.
Now flatc will take advanced input for conformance check if any language is specified.
However, if no language specified, it will works the same as now.
PS: I was looking where can I put tests for conform option but it seems to be not trivial to add all required files to unit tests while did not find a good place to check it with command line. Happy to add if there is one.