remove documentation of former versions - it's available in the commit history #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 30, 2017 16:25
The documentation of former versions is available in the history (e.g. by checking out the appropriate git tags), so there is no need to keep them in parallel to the current documentation.
The documentation of former versions is available in the history (e.g. by checking out the appropriate git tags), so there is no need to keep them in parallel to the current documentation.
|
Sadly , looks out of date, please fix the merge conflicts |
googletest/docs/Documentation.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| This page lists all documentation wiki pages for Google Test **(the SVN trunk version)** | |||
| This page lists all documentation markdown files for Google Test **(the | |||
| current git version)** | |||
| -- **if you use a released version of Google Test, please read the | |||
There was a problem hiding this comment.
I would not say "released", I would say "an older version"
There was a problem hiding this comment.
I will take "former version" as you mentioned in the discussion.
|
I agree in principle. Could you please change the wording a bit, be careful with "released version" terminology,. In essence we are saying that " former versions can easily be found by checking out the appropriate git tags" so lets be consistent and say "former versions" everywhere and not go into the "released" versions |
|
The term "released version" was already in the documentation before my changes, but you're right, "former version" is better. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As former versions can easily be found by checking out the appropriate git tags, I see no need to keep the old documentation in parallel to the current documentation.
There is also some reference to SVN trunk, which is obsolete, and one link in the googlemock documentation to the pump documentation can be fixed.