-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cmake build type defined in .travis.yml for travis builds #1235
Conversation
The BUILD_TYPE variable of .travis.yml was ignored up to now.
While cmake does not complain on build type 'debug', the cmake documentation always spells it 'Debug', so take this.
As expected, Travis build 853 is failing, i.e. CTest is failing with error messages as the following:
The build type |
On single-configuration build systems as Makefile Generators, there is no subdirectory for the configuration in the build tree - therefore ask cmake for the subdir by using CMAKE_CFG_INTDIR, which is just '.' on single-configuration build systems (Linux et al.).
Ok, unfortunately, |
This reverts commit 73d58dd. Unfortunately, ${CMAKE_CFG_INTDIR} is set during build only and doesn't help here.
…n build generators
@gennadiycivil As soon as AppVeyor has finished, this is ready for review :-) |
Looks mostly good to me - but can we add tests for positive proof? |
@gennadiycivil - I already tried to create comments here in sequence to show this, sorry that it wasn't obvious enough. The failing build is mentioned in this comment with a link to the build logs, after turning on the build type in travis.sh in commit cc246 - together with commit dae04 to use the CMake typical The following commits, i.e. the changes in googletest/cmake/internal_utils.cmake, fix the build path given to Python. This path was o.k. for Windows, i.e. added e.g. |
Hmm, Travis build 888.6 timed out after a warning, probably not source code related? Will merge master into this branch to see the result of the next build. |
Currently, the
BUILD_TYPE
variable of.travis.yml
was ignored up to now bytravis.sh
and the build process.Also, while cmake does not complain on build type
debug
(as listed in .travis.yml currently), the cmake documentation always spells itDebug
, so take this.Using the variable in
travis.sh
to callcmake -DCMAKE_BUILD_TYPE=Debug
leads to the problem reported in issue #1175, i.e. some Python driven tests won't find their test executable.The travis build triggered by the first commits here will probably fail; then a fix can be tested and discussed.
This pull request fixes #1175 and #1070.