Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

fix info and setting fragment profile menu item click #359

Open
wants to merge 5 commits into
base: iosched_2020
Choose a base branch
from

Conversation

kareemradwan
Copy link

I fixed the bug in Profile Menu Item Click in Info and Setting Fragments

@google-cla
Copy link

google-cla bot commented Sep 11, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 11, 2020
@kareemradwan
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 11, 2020
Copy link
Collaborator

@jdkoren jdkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few nits: there are some lines with whitespace changes and one with a new line-break. These aren't necessary and don't follow the existing style in the affected files.

We have a code style in tools/iosched-codestyle.xml, you can import this in Android studio and use it for this project and that should take care of the formatting.

@kareemradwan
Copy link
Author

@jdkoren
sure. I will do it

@kareemradwan
Copy link
Author

@jdkoren can you review the code?

<option name="CONTINUATION_INDENT_SIZE" value="4" />
</indentOptions>
</codeStyleSettings>
<code_scheme name="iosched"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not source code and should not be formatted as such (it is never edited directly). Please revert.

@@ -39,3 +39,4 @@ _sandbox

# Android Studio captures folder
captures/
tools/iosched-codestyle.xml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not supposed to be ignored. We check it in so that others (like yourself) can use the same code style when contributing to the project. Please revert this change and revert the changes to that file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line still needs to be removed.

inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
inflater: LayoutInflater,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo these whitespace changes

R.string.event_title,
R.string.travel_title,
R.string.faq_title
R.string.event_title,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo these whitespace changes

inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
inflater: LayoutInflater,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo these whitespace changes

.setView(webView)
.create()
.show()
.setTitle(dialogTitle)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo these whitespace changes

@@ -39,3 +39,4 @@ _sandbox

# Android Studio captures folder
captures/
tools/iosched-codestyle.xml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line still needs to be removed.

Base automatically changed from master to main February 11, 2021 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants