Ensure CTAs don’t appear for view-only users

[techanvil]

Feature Description

Ensure CTAs for setting the feature up and creating resources, and the link to the Settings section in the Selection Panel don’t appear for view-only users.

See dashboard sharing in the design doc.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When on the view-only dashboard, no Audience Segmentation CTAs should be displayed as the user won’t have permission to action them:
  • The Setup CTA Banner should not be displayed.
  • The Audience Creation Notice in the Selection Panel should not be displayed.
  • The link to the Settings section in the Selection Panel should not be displayed.

Implementation Brief

• Update assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/index.js, use the useViewOnly hook to only render the AudienceCreationNotice outside of the view only context.
• Note: AudienceSegmentationSetupCTAWidget.js is already hidden in the view only context.
• Note: the settings link is already hidden in the view only context.

Test Coverage

• Update VRTs. No additional tests required.

QA Brief

• Connect/create a property that requires the Site Kit audiences to be created.
• Switch to a view only user.
• The Audience Creation notice should not show in this context.
• Ensure that the other CTAs mentioned in the ACs do not appear in the view only dashboard as well.

Changelog entry

• Enhance Audience Segmentation CTAs to not appear on shared dashboard.

[techanvil]

Hi @hussain-t, just a heads up that I've tweaked the requirement for this issue to include removing the link to the settings section in the selection panel for view-only users.

[kuasha420]

Thank you @benbowler for working on this IB. A couple of points.

1. Looks like AudienceSegmentationSetupCTAWidget is not being rendered on shared dashboard anyways as it's guarded in assets/js/components/DashboardMainApp.js.
2. We also should follow similar pattern for AddGroupNotice, by preventing it from rendering in shared dashboard in assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/index.js.

Thanks.

[benbowler]

Thanks @kuasha420, updated!

[kuasha420]

IB ✔️

[hussain-t]

We don’t have an easy way to view the Audience Segmentation widgets until #8130 is implemented. Therefore, I’ve updated the dependency. This task should be worked on once #8130 is completed.

cc: @techanvil @ivonac4

[kelvinballoo]

QA Update ⚠️

Under the view mode, I was not able to see the tiles.
I can't access the selection panel to verify that the notice doesn't appear.
Am I missing any steps here?

Video is below for reference.

SK.view.only.doesn.t.appear.mov

[benbowler]

Hey @kelvinballoo, as this ticket is waiting on #8130, it won't be testable until that ticket is merged.

[kelvinballoo]

QA Update ✅

Thanks @benbowler for the clarification.
Since this is behind a feature flag, I am marking this ticket as Pass and I added a note here for the QAB of #8130 to be updated to include the testing of #8174.

Moving ticket to Approval.