Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/#8165 - Implement the Audience Creation Notice OAuth flow #9206

Merged
merged 16 commits into from
Aug 21, 2024

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Aug 19, 2024

Summary

Addresses issue:

Relevant technical choices

  • I opted to keep the audience creation and auto-submit logic within the AudienceCreationNotice component rather than moving it to the parent component as initially outlined in the IB. This approach maintains a cleaner, more encapsulated component structure and avoids unnecessary prop drilling and side effects in the existing tests.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Aug 19, 2024

Build files for d3e985b have been deleted.

Copy link

github-actions bot commented Aug 19, 2024

Size Change: +2.42 kB (+0.14%)

Total Size: 1.79 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 57.5 kB +423 B (+0.74%)
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB -1 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.7 kB -29 B (-0.04%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-api-********************.js 9.95 kB -2 B (-0.02%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.97 kB -1 B (-0.02%)
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB +5 B (+0.21%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.3 kB -2 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.88 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.1 kB +12 B (+0.05%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 82.9 kB -36 B (-0.04%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 153 kB +341 B (+0.22%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -7 B (-0.03%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB -14 B (-0.05%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB -93 B (-0.07%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 166 kB +920 B (+0.56%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.4 kB +6 B (+0.03%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 20.5 kB -3 B (-0.01%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.5 kB -30 B (-0.05%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB -4 B (-0.01%)
./dist/assets/js/googlesitekit-notifications-********************.js 21.6 kB -10 B (-0.05%)
./dist/assets/js/googlesitekit-settings-********************.js 82.5 kB -50 B (-0.06%)
./dist/assets/js/googlesitekit-splash-********************.js 88.6 kB -13 B (-0.01%)
./dist/assets/js/googlesitekit-user-input-********************.js 62.5 kB -42 B (-0.07%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB +7 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 82.7 kB +1.04 kB (+1.28%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB -10 B (-0.02%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.94 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @hussain-t!

@techanvil techanvil merged commit 7c1e93d into develop Aug 21, 2024
20 of 21 checks passed
@techanvil techanvil deleted the enhancement/#8165-audience-creation-oauth-flow branch August 21, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants