Enhancement/8978 Refactor UnsatisfiedScopesAlert

[jimmymadon]

Summary

Addresses issue:

• Refactor the UnsatisfiedScopesAlert to use the new Notifications datastore and layout components #8978

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for 4025a49 have been deleted.

[github-actions]

Size Change: +1.58 kB (+0.09%)

Total Size: 1.79 MB

Filename	Size	Change
./dist/assets/js/36-********************.js	3.12 kB	-1 B (-0.03%)
./dist/assets/js/googlesitekit-activation-********************.js	23.8 kB	-3 B (-0.01%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	71.4 kB	-1.05 kB (-1.45%)
./dist/assets/js/googlesitekit-adminbar-********************.js	34.5 kB	-5 B (-0.01%)
./dist/assets/js/googlesitekit-api-********************.js	9.99 kB	-2 B (-0.02%)
./dist/assets/js/googlesitekit-components-gm2-********************.js	5.97 kB	-2 B (-0.03%)
./dist/assets/js/googlesitekit-components-gm3-********************.js	10.1 kB	+3 B (+0.03%)
./dist/assets/js/googlesitekit-data-********************.js	2.35 kB	+2 B (+0.09%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	8.96 kB	-3 B (-0.03%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	20.4 kB	+3 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.92 kB	+2 B (+0.02%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	83.2 kB	-701 B (-0.84%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js	154 kB	-521 B (-0.34%)
./dist/assets/js/googlesitekit-modules-********************.js	22.2 kB	-28 B (-0.13%)
./dist/assets/js/googlesitekit-modules-ads-********************.js	29.5 kB	-19 B (-0.06%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	125 kB	+347 B (+0.28%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	168 kB	+100 B (+0.06%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	22.6 kB	+9 B (+0.04%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js	21.6 kB	+204 B (+0.95%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	58.7 kB	+29 B (+0.05%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	31.9 kB	+36 B (+0.11%)
./dist/assets/js/googlesitekit-notifications-********************.js	17.9 kB	+1.62 kB (+9.96%)	⚠️
./dist/assets/js/googlesitekit-polyfills-********************.js	377 B	-1 B (-0.26%)
./dist/assets/js/googlesitekit-settings-********************.js	83.1 kB	+418 B (+0.51%)
./dist/assets/js/googlesitekit-splash-********************.js	89.4 kB	+578 B (+0.65%)
./dist/assets/js/googlesitekit-user-input-********************.js	63.2 kB	+479 B (+0.76%)
./dist/assets/js/googlesitekit-vendor-********************.js	321 kB	+9 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js	85.3 kB	+55 B (+0.06%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	61.6 kB	+19 B (+0.03%)
./dist/assets/js/runtime-********************.js	1.3 kB	+1 B (+0.08%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	57.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css	846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	8.2 kB
./dist/assets/js/31-********************.js	2.76 kB
./dist/assets/js/32-********************.js	2.25 kB
./dist/assets/js/33-********************.js	3.64 kB
./dist/assets/js/34-********************.js	935 B
./dist/assets/js/35-********************.js	892 B
./dist/assets/js/analytics-advanced-tracking-********************.js	901 B
./dist/assets/js/googlesitekit-consent-mode-********************.js	25.6 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js	26.1 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js	646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js	624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js	630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js	712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js	675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js	634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js	657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js	633 B
./dist/assets/js/googlesitekit-i18n-********************.js	3.93 kB

_{compressed-size-action}

[tofumatt]

I just have a few comments on the code itself, all quite minor.

But when I tried to get the Gathering data notification to appear by setting up Site Kit on my development site with the Tester Plugin, I never saw the notification 🤔

Based on the QA Brief I expected it to appear, but nothing did.

[jimmymadon]

@tofumatt Thanks for the review. This seems better now. Was going crazy with all the testing so missed checking the remaining notifications after my last few modifications.

[tofumatt]

Looks good 👍🏻

[tofumatt]

VRT failure here is totally unrelated, so I'm fixing it here then merging this. 😅