Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / 9130 Changes for Approval Into Main #9310

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

10upsimon
Copy link
Collaborator

@10upsimon 10upsimon commented Sep 5, 2024

Summary

Addresses issue:

Relevant technical choices

  • Updated code and renamed properties to be indicative of events_sync as opposed to events_check
  • Updated inline comments, var declarations and property references to match changes above

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Sep 5, 2024

Build files for 1c0199f have been deleted.

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @10upsimon. One more thing, can we rename Conversion_Reporting_Events_Sync::check_for_events to sync_detected_events? I think that would be more clear as to what it's doing and more consistent with the naming.

@aaemnnosttv aaemnnosttv merged commit bbfc158 into main Sep 6, 2024
19 checks passed
@aaemnnosttv aaemnnosttv deleted the fix/9130-changes-for-approval-into-main branch September 6, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants