-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/8179 audience settings unhappy setup path #9327
Merged
hussain-t
merged 5 commits into
develop
from
enhance/8179-audience-settings-unhappy-setup-path
Sep 20, 2024
Merged
Enhance/8179 audience settings unhappy setup path #9327
hussain-t
merged 5 commits into
develop
from
enhance/8179-audience-settings-unhappy-setup-path
Sep 20, 2024
+266
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 3919b7e Author: Tom Rees-Herdman <tom.rees-herdman@10up.com> Date: Wed Sep 4 13:24:57 2024 +0100 Tidy up debug comments. commit ab1ce2d Author: Tom Rees-Herdman <tom.rees-herdman@10up.com> Date: Wed Sep 4 13:20:15 2024 +0100 Add PoC support for an error redirect URL for OAuth errors. This allows the default behaviour which is to redirect to the dashboard or splash screen to be overridden, e.g. to allow the user to return to the Settings screen on an OAuth error.
Build files for a7fb98d have been deleted. |
2 tasks
Size Change: +46.7 kB (+2.58%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
hussain-t
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @kuasha420 and @benbowler. LGTM 👍
I've verified that the test failures are unrelated to this PR. |
hussain-t
deleted the
enhance/8179-audience-settings-unhappy-setup-path
branch
September 20, 2024 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
Note from @benbowler, I took this over as of 13 September 2024. Updating the flow and adding thorough tests.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist