Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ByteSlice::split_at into separate trait #1

Closed
joshlf opened this issue Sep 19, 2022 · 0 comments · Fixed by #991
Closed

Split ByteSlice::split_at into separate trait #1

joshlf opened this issue Sep 19, 2022 · 0 comments · Fixed by #991
Labels
compatibility-breaking Changes that are (likely to be) breaking

Comments

@joshlf
Copy link
Member

joshlf commented Sep 19, 2022

Migrated from https://fxbug.dev/76635

Currently, we don't implement ByteSlice for Vec<u8> because it would be expensive to implement the split_at method. However, most uses of ByteSlice don't make use of this method. We should split ByteSlice into multiple traits and only use the trait with the split_at method where it's actually necessary. Vec can then implement the base trait but not the trait with the split_at method.

Possible names for these traits: ByteSlice and SplittableByteSlice.
@joshlf joshlf added the blocking-next-release This issue should be resolved before we release on crates.io label Oct 15, 2022
@joshlf joshlf mentioned this issue Oct 23, 2022
Open
@joshlf joshlf added compatibility-breaking Changes that are (likely to be) breaking and removed blocking-next-release This issue should be resolved before we release on crates.io labels Aug 12, 2023
@joshlf joshlf mentioned this issue Dec 4, 2023
Open
81 tasks
joshlf added a commit that referenced this issue Mar 1, 2024
@joshlf
Split ByteSlice and SplitByteSlice
8502377 
TODO:
- Consider making these traits un-sealed
- Implement ByteSlice and ByteSliceMut for Vec<u8>

Closes #1
This was referenced Mar 1, 2024
Merged
Open
joshlf added a commit that referenced this issue Mar 1, 2024
@joshlf
Split ByteSlice and SplitByteSlice
c6da3ab 
Closes #1
joshlf added a commit that referenced this issue Mar 1, 2024
@joshlf
Split ByteSlice and SplitByteSlice
894aaea 
Closes #1
joshlf added a commit that referenced this issue Mar 1, 2024
@joshlf
Split ByteSlice and SplitByteSlice
d8485e6 
Closes #1
github-merge-queue bot pushed a commit that referenced this issue Mar 1, 2024
@joshlf
Split ByteSlice and SplitByteSlice (#991)
184dedf 
Closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-breaking Changes that are (likely to be) breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split ByteSlice and SplitByteSlice google/zerocopy
1 participant
@joshlf