-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on byteorder
crate, make byteorder
type methods const
#438
Closed
1 of 3 tasks
Labels
blocking-next-release
This issue should be resolved before we release on crates.io
compatibility-breaking
Changes that are (likely to be) breaking
Comments
joshlf
changed the title
Make methods on
Remove dependency on Oct 1, 2023
byteorder
types const fn
sbyteorder
crate
joshlf
added
compatibility-breaking
Changes that are (likely to be) breaking
blocking-next-release
This issue should be resolved before we release on crates.io
labels
Oct 1, 2023
joshlf
changed the title
Remove dependency on
Remove dependency on Oct 1, 2023
byteorder
cratebyteorder
crate, make byteorder
type methods const
Closed
joshlf
added a commit
that referenced
this issue
Nov 1, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This allows us to make some of our functions and methods `const`. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Dec 6, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This allows us to make some of our functions and methods `const`. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Dec 6, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This allows us to make some of our functions and methods `const`. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Dec 6, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This allows us to make some of our functions and methods `const`. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Dec 28, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This prepares us for a future commit in which we will make some of our functions and methods `const`. This commit doesn't implement this yet because it doesn't play nicely with our current MSRV; in order to support this, we'll need to introduce machinery that allows us to compile functions as conditionally `const` depending on what Rust toolchain version is used. See #574 for a prototype of this machinery. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Dec 28, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This prepares us for a future commit in which we will make some of our functions and methods `const`. This commit doesn't implement this yet because it doesn't play nicely with our current MSRV; in order to support this, we'll need to introduce machinery that allows us to compile functions as conditionally `const` depending on what Rust toolchain version is used. See #574 for a prototype of this machinery. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Dec 28, 2023
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This prepares us for a future commit in which we will make some of our functions and methods `const`. This commit doesn't implement this yet because it doesn't play nicely with our current MSRV; in order to support this, we'll need to introduce machinery that allows us to compile functions as conditionally `const` depending on what Rust toolchain version is used. See #574 for a prototype of this machinery. Add `Usize` and `Isize` byte order-aware types. Closes #438
joshlf
added a commit
that referenced
this issue
Jan 18, 2024
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This prepares us for a future commit in which we will make some of our functions and methods `const`. This commit doesn't implement this yet because it doesn't play nicely with our current MSRV; in order to support this, we'll need to introduce machinery that allows us to compile functions as conditionally `const` depending on what Rust toolchain version is used. See #574 for a prototype of this machinery. Add `Usize` and `Isize` byte order-aware types. Closes #438
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 18, 2024
Remove the `byteorder` feature and the dependency on the `byteorder` crate. Replace the `ByteOrder` trait and types which implement it from the `byteorder` crate with our own native implementations. This prepares us for a future commit in which we will make some of our functions and methods `const`. This commit doesn't implement this yet because it doesn't play nicely with our current MSRV; in order to support this, we'll need to introduce machinery that allows us to compile functions as conditionally `const` depending on what Rust toolchain version is used. See #574 for a prototype of this machinery. Add `Usize` and `Isize` byte order-aware types. Closes #438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocking-next-release
This issue should be resolved before we release on crates.io
compatibility-breaking
Changes that are (likely to be) breaking
Summary
Remove our dependency on the
byteorder
crate and remove thebyteorder
feature, making thebyteorder
module available unconditinoally.Progress
In progress in #583.
const fn
s no longer beconst
so that it works with our MSRVconst
depending on Rust version (as prototyped in #574)const
Description
Some potential users have expressed concerns over our dependency on the byteorder crate. I have not seen any uses of the types in our
byteorder
module which mix those types with other uses of the byteorder crate, which implies that we could just define our ownByteOrder
trait rather than using the one from the byteorder crate and this wouldn't cause problems for users.While we're at it, we could use a technique like the following to allow the methods on our types to be
const fn
s:The text was updated successfully, but these errors were encountered: