Skip to content

Commit

Permalink
Update deps in generated csproj files (#276)
Browse files Browse the repository at this point in the history
And add a direct reference to Google.Protobuf, to get the latest version as required by the latest protoc-generated files
  • Loading branch information
chrisdunelm committed Sep 14, 2020
1 parent 172c5e6 commit ed955c9
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Google.Api.Gax.Grpc.GrpcCore" Version="3.0.0-beta01" />
<PackageReference Include="Grpc.Core" Version="2.27.0" />
<PackageReference Include="Google.Api.Gax.Grpc.GrpcCore" Version="3.1.0" />
<PackageReference Include="Grpc.Core" Version="2.32.0" />
<PackageReference Include="Google.Protobuf" Version="3.13.0" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Google.Api.Gax.Grpc.GrpcCore" Version="3.0.0-beta01" />
<PackageReference Include="Grpc.Core" Version="2.27.0" />
<PackageReference Include="Google.LongRunning" Version="2.0.0-beta01" />
<PackageReference Include="Google.Api.Gax.Grpc.GrpcCore" Version="3.1.0" />
<PackageReference Include="Grpc.Core" Version="2.32.0" />
<PackageReference Include="Google.Protobuf" Version="3.13.0" />
<PackageReference Include="Google.LongRunning" Version="2.0.0" />
</ItemGroup>

</Project>
10 changes: 6 additions & 4 deletions Google.Api.Generator/Generation/CsProjGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ namespace Google.Api.Generator.Generation
{
internal static class CsProjGenerator
{
private const string GaxGrpcCoreVersion = "3.0.0-beta01";
private const string GrpcCoreVersion = "2.27.0";
private const string LroVersion = "2.0.0-beta01";
private const string GaxGrpcCoreVersion = "3.1.0";
private const string GrpcCoreVersion = "2.32.0";
private const string LroVersion = "2.0.0";
private const string ProtobufVersion = "3.13.0"; // Required due to incompatibility between GAX and the protoc version used by the bazel rules.

public static string GenerateClient(bool hasLro)
{
Expand Down Expand Up @@ -72,7 +73,8 @@ public static string GenerateClient(bool hasLro)
<ItemGroup>
<PackageReference Include=""Google.Api.Gax.Grpc.GrpcCore"" Version=""{GaxGrpcCoreVersion}"" />
<PackageReference Include=""Grpc.Core"" Version=""{GrpcCoreVersion}"" />{packageRefs}
<PackageReference Include=""Grpc.Core"" Version=""{GrpcCoreVersion}"" />
<PackageReference Include=""Google.Protobuf"" Version=""{ProtobufVersion}"" />{packageRefs}
</ItemGroup>
</Project>
Expand Down

0 comments on commit ed955c9

Please sign in to comment.