Skip to content

Commit

Permalink
feat!: drop Node 12 & decouple development dependencies (#1439)
Browse files Browse the repository at this point in the history
* feat!: get tools scripts and dependencies running; still need to get top-level module running without tools, remove extra dependencies, and make sure to run commands from the tools dependency

* move to node 14
---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
sofisl and gcf-owl-bot[bot] committed May 17, 2023
1 parent 8e6888f commit 61a7143
Show file tree
Hide file tree
Showing 54 changed files with 4,323 additions and 80 deletions.
13 changes: 8 additions & 5 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,15 @@ branchProtectionRules:
- "ci/kokoro: System test"
- "ci/kokoro: Browser test"
- docs
- lint
- test (12)
- test (14)
- test (16)
- lint-gax
- lint-tools
- test-gax (14)
- test-gax (16)
- test-tools (14)
- test-tools (16)
- cla/google
- windows
- windows-gax
- windows-tools
- OwlBot Post Processor
permissionRules:
- team: yoshi-admins
Expand Down
49 changes: 45 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ on:
pull_request:
name: ci
jobs:
test:
test-gax:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16]
node: [14, 16]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -26,7 +26,28 @@ jobs:
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
windows:
test-tools:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: node --version
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
# dependencies that don't match our engines field:
- run: cd tools; npm install --engine-strict --no-package-lock
# Clean up the production install, before installing dev/production:
- run: cd tools; rm -rf node_modules
- run: cd tools; npm install
- run: cd tools; npm test
env:
MOCHA_THROW_DEPRECATION: false
windows-gax:
runs-on: windows-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -37,7 +58,18 @@ jobs:
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
lint:
windows-tools:
runs-on: windows-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
- run: cd tools; npm install
- run: cd tools; npm test
env:
MOCHA_THROW_DEPRECATION: false
lint-gax:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -46,6 +78,15 @@ jobs:
node-version: 14
- run: npm install
- run: npm run lint
lint-tools:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
- run: cd tools; npm install
- run: cd tools; npm run lint
docs:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/continuous/node12/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions .kokoro/continuous/node14/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .kokoro/continuous/node14/lint.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions .kokoro/continuous/node14/samples-test.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions .kokoro/continuous/node14/system-test.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
2 changes: 1 addition & 1 deletion .kokoro/presubmit/node12/browser-test.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/presubmit/node12/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions .kokoro/publish-single.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 15 additions & 20 deletions .kokoro/publish.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/release/docs.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/release/publish.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

import synthtool.languages.node as node

node.owlbot_main(templates_excludes=["LICENSE", "README.md", ".github/sync-repo-settings.yaml"])
node.owlbot_main(templates_excludes=["LICENSE", "README.md", ".github/sync-repo-settings.yaml", ".github/workflows/ci.yaml",".kokoro/", ".kokoro/continuous/node12/common.cfg", ".kokoro/presubmit/node12/common.cfg", ".kokoro/release/docs.cfg", ".kokoro/release/publish.cfg"])
Loading

0 comments on commit 61a7143

Please sign in to comment.