fix: remove retryDelay option (#203)

googleapis · Dec 16, 2019 · d21e08d · d21e08d
1 parent 5cdeef2
commit d21e08d
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -107,9 +107,6 @@ gaxios.request({url: '/data'}).then(...);
     // The number of retries already attempted.
     currentRetryAttempt?: number;
 
-    // The amount of time to initially delay the retry.  Defaults to 100.
-    retryDelay?: number;
-
     // The HTTP Methods that will be automatically retried.
     // Defaults to ['GET','PUT','HEAD','OPTIONS','DELETE']
     httpMethodsToRetry?: string[];

diff --git a/src/common.ts b/src/common.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -114,6 +114,7 @@ export interface RetryConfig {
 
   /**
    * The amount of time to initially delay the retry.  Defaults to 100.
+   * @deprecated
    */
   retryDelay?: number;
 

diff --git a/src/gaxios.ts b/src/gaxios.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at

diff --git a/src/index.ts b/src/index.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at

diff --git a/src/retry.ts b/src/retry.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -22,7 +22,6 @@ export async function getRetryConfig(err: GaxiosError) {
   config.currentRetryAttempt = config.currentRetryAttempt || 0;
   config.retry =
     config.retry === undefined || config.retry === null ? 3 : config.retry;
-  config.retryDelay = config.retryDelay || 100;
   config.httpMethodsToRetry = config.httpMethodsToRetry || [
     'GET',
     'HEAD',

diff --git a/test/test.getch.ts b/test/test.getch.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at

diff --git a/test/test.index.ts b/test/test.index.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at

diff --git a/test/test.retry.ts b/test/test.retry.ts
@@ -1,4 +1,4 @@
-// Copyright 2018, Google, LLC.
+// Copyright 2018 Google LLC
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -50,7 +50,6 @@ describe('🛸 retry & exponential backoff', () => {
       assert.strictEqual(config!.currentRetryAttempt, 3);
       assert.strictEqual(config!.retry, 3);
       assert.strictEqual(config!.noResponseRetries, 2);
-      assert.strictEqual(config!.retryDelay, 100);
       const expectedMethods = ['GET', 'HEAD', 'PUT', 'OPTIONS', 'DELETE'];
       for (const method of config!.httpMethodsToRetry!) {
         assert(expectedMethods.indexOf(method) > -1);