address review comments; fix clang otel disabled

googleapis · Mar 17, 2023 · 985901b · 985901b
1 parent 7ee82fd
commit 985901b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/google/cloud/internal/opentelemetry.cc b/google/cloud/internal/opentelemetry.cc
@@ -99,15 +99,16 @@ std::function<void(std::chrono::milliseconds)> MakeTracedSleeper(
   return sleeper;
 }
 
-// NOLINTNEXTLINE(misc-unused-value-param)
-void AddSpanAttribute(std::string const& key, std::string const& value) {
 #ifdef GOOGLE_CLOUD_CPP_HAVE_OPENTELEMETRY
+void AddSpanAttribute(std::string const& key, std::string const& value) {
   if (TracingEnabled(CurrentOptions())) {
     auto span = opentelemetry::trace::Tracer::GetCurrentSpan();
-    span->SetAttribute(std::move(key), std::move(value));
+    span->SetAttribute(key, value);
   }
-#endif  // GOOGLE_CLOUD_CPP_HAVE_OPENTELEMETRY
 }
+#else
+void AddSpanAttribute(std::string const&, std::string const&) {}
+#endif  // GOOGLE_CLOUD_CPP_HAVE_OPENTELEMETRY
 
 }  // namespace internal
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END