Skip to content

Commit

Permalink
fix(oauth2): only enable via GOOGLE_CLOUD_CPP_ENABLE
Browse files Browse the repository at this point in the history
Enabling `oauth2` if `GOOGLE_CLOUD_CPPP_ENABLE_REST` is set is a bug: it
introduces a cycle in the dependencies of the library, and makes it
impossible to compile `oauth2`, `storage`, and `compute` in different
shards.
  • Loading branch information
coryan committed Oct 16, 2023
1 parent 7ecfaa1 commit 9dc2643
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cmake/GoogleCloudCppFeatures.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,6 @@ macro (google_cloud_cpp_enable_cleanup)
OR (sql IN_LIST GOOGLE_CLOUD_CPP_ENABLE)
OR (generator IN_LIST GOOGLE_CLOUD_CPP_ENABLE))
set(GOOGLE_CLOUD_CPP_ENABLE_REST ON)
# Backwards compatibility. In the original release of `oauth2` we
# automatically compiled the library if REST was enabled
list(APPEND GOOGLE_CLOUD_CPP_ENABLE oauth2)
endif ()

list(REMOVE_DUPLICATES GOOGLE_CLOUD_CPP_ENABLE)
Expand Down

0 comments on commit 9dc2643

Please sign in to comment.